From f3b929d98cac3286eeeff1799c338bee881c21c6 Mon Sep 17 00:00:00 2001 From: Borja De Macedo Date: Thu, 22 Feb 2024 10:29:05 +0100 Subject: [PATCH 1/3] fix(bundle): remove rebuild because it causes slow performance on big projects --- src/bundle.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/bundle.ts b/src/bundle.ts index 41373e9..c6d7960 100644 --- a/src/bundle.ts +++ b/src/bundle.ts @@ -107,12 +107,7 @@ export async function bundle(this: EsbuildServerlessPlugin): Promise { type ContextFn = (opts: typeof options) => Promise; type WithContext = typeof pkg & { context?: ContextFn }; const context = await (pkg as WithContext).context?.(options); - - let result = await context?.rebuild(); - - if (!result) { - result = await pkg.build(options); - } + const result = await pkg.build(options); if (config.metafile) { fs.writeFileSync( From 2536414fbc372b6198d111e349356bfc033e62d5 Mon Sep 17 00:00:00 2001 From: Borja De Macedo Date: Tue, 5 Mar 2024 12:40:15 +0100 Subject: [PATCH 2/3] feat(bundle): add skipRebuild option --- src/bundle.ts | 11 ++++++++++- src/types.ts | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/bundle.ts b/src/bundle.ts index c6d7960..891263f 100644 --- a/src/bundle.ts +++ b/src/bundle.ts @@ -107,7 +107,16 @@ export async function bundle(this: EsbuildServerlessPlugin): Promise { type ContextFn = (opts: typeof options) => Promise; type WithContext = typeof pkg & { context?: ContextFn }; const context = await (pkg as WithContext).context?.(options); - const result = await pkg.build(options); + + let result; + if (!buildOptions.skipRebuild) { + result = await context?.rebuild(); + if (!result) { + result = await pkg.build(options); + } + } else { + result = await pkg.build(options); + } if (config.metafile) { fs.writeFileSync( diff --git a/src/types.ts b/src/types.ts index f3c8115..9ba69a5 100644 --- a/src/types.ts +++ b/src/types.ts @@ -46,6 +46,7 @@ export interface Configuration extends EsbuildOptions { outputFileExtension: '.js' | '.cjs' | '.mjs'; nodeExternals?: NodeExternalsOptions; skipBuild?: boolean; + skipRebuild?: boolean; skipBuildExcludeFns: string[]; stripEntryResolveExtensions?: boolean; disposeContext?: boolean; From ee7fef10f586c41d45a85bb3f67eed28fd419b2e Mon Sep 17 00:00:00 2001 From: Borja De Macedo Date: Thu, 7 Mar 2024 10:08:38 +0100 Subject: [PATCH 3/3] docs: add skipRebuild option --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index fc4be68..51f07f1 100644 --- a/README.md +++ b/README.md @@ -89,6 +89,7 @@ See [example folder](examples) for some example configurations. | `packagerOptions` | Extra options for packagers for `external` dependency resolution. | [Packager Options](#packager-options) | | `watch` | Watch options for `serverless-offline`. | [Watch Options](#watch-options) | | `skipBuild` | Avoid rebuilding lambda artifacts in favor of reusing previous build artifacts. | `false` | +| `skipRebuild` | A boolean defining whether rebuild is avoided. Generally rebuild produces faster builds but in some context scenarios with many lambdas or low memory computer (like Github Actions) it can cause memory leaks. | `false` | | `skipBuildExcludeFns` | An array of lambda names that will always be rebuilt if `skipBuild` is set to `true` and bundling individually. This is helpful for dynamically generated functions like serverless-plugin-warmup. | `[]` | | `stripEntryResolveExtensions` | A boolean that determines if entrypoints using custom file extensions provided in the `resolveExtensions` ESbuild setting should be stripped of their custom extension upon packing the final bundle for that file. Example: `myLambda.custom.ts` would result in `myLambda.js` instead of `myLambda.custom.js`. | `disposeContext` | An option to disable the disposal of the context.(Functions can override the global `disposeContext` configuration by specifying their own `disposeContext` option in their individual configurations.) | `true`