Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fluent-bit flushSeconds should support fractional values #1405

Closed
jjsiv opened this issue Nov 8, 2024 · 0 comments · Fixed by #1406
Closed

bug: fluent-bit flushSeconds should support fractional values #1405

jjsiv opened this issue Nov 8, 2024 · 0 comments · Fixed by #1406

Comments

@jjsiv
Copy link
Collaborator

jjsiv commented Nov 8, 2024

Describe the issue

It is currently not possible to use fractional values for flushSeconds, e.g 0.1s. My suggestion is to change it to float. This shouldn't break backwards compatibility

To Reproduce

apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterFluentBitConfig
metadata:
  name: fluent-bit-config
spec:
  inputSelector:
    matchLabels:
      fluentbit.fluent.io/enabled: "true"
  outputSelector:
    matchLabels:
      fluentbit.fluent.io/enabled: "true"
  service:
    flushSeconds: 0.1

Expected behavior

ClusterFluentBitConfig supports fractional values for flushSeconds

Your Environment

- Fluent Operator version:
- Container Runtime:
- Operating system:
- Kernel version:

How did you install fluent operator?

No response

Additional context

Even though official fluent-bit docs describe the value for Flush as int type, it is in fact a double
https://github.com/fluent/fluent-bit/blob/master/include/fluent-bit/flb_config.h#L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant