Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LauncherIcon and LauncherText of RibbonGroupBox are not applied to the appearance #941

Closed
nishy2000 opened this issue May 23, 2021 · 0 comments · Fixed by #942
Closed

LauncherIcon and LauncherText of RibbonGroupBox are not applied to the appearance #941

nishy2000 opened this issue May 23, 2021 · 0 comments · Fixed by #942
Labels
Bug 🐞
Milestone
9.0

Comments

@nishy2000
Copy link
Contributor

LauncherIcon and LauncherText of RibbonGroupBox are not applied to the appearance.

LauncherIcon is set to RibbonGroupBox, but the built-in icon will always be used.
LauncherText is set to RibbonGroupBox, but it is not used.

<Fluent:RibbonGroupBox x:Name="Font"
                       Header="Font"
                       StateDefinition="Large,Middle,Small"
                       KeyTip="F"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/FontColor.png"
                       IsLauncherVisible="True"
                       LauncherClick="OnLauncherButtonClick"
                       LauncherKeys="NF"
                       LauncherIcon="/Images/FontColor.png">

Incorrect:
LauncherIcon-incorrect

Correct:
LauncherIcon-correct

Environment

  • Fluent.Ribbon 9.0.0 preview (latest develop branch [7fb28fb])
  • Windows 10 Pro 21H1
  • .NET Framework 4.6.2 / net5.0-windows
nishy2000 added a commit to nishy2000/Fluent.Ribbon that referenced this issue May 23, 2021
@nishy2000
fix: the built-in launcher icon will always be used
681bd51 
fix fluentribbon#941
@nishy2000 nishy2000 mentioned this issue May 23, 2021
Merged
batzen added a commit that referenced this issue May 23, 2021
@batzen
Merge pull request #942 from nishy2000/hotfix-941-LauncherIcon-is-not…
3833af5 
…-applied

fix for #941 (LauncherIcon of RibbonGroupBox is not applied)
batzen added a commit that referenced this issue May 23, 2021
@batzen
Adding #941 to changelog
adc78d7
@batzen batzen added this to the 9.0 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

fix for #941 (LauncherIcon of RibbonGroupBox is not applied) nishy2000/Fluent.Ribbon
2 participants
@batzen @nishy2000