Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unlocking user accounts by e-mail only #16

Closed
jobara opened this issue Dec 10, 2020 · 0 comments
Closed

Allow unlocking user accounts by e-mail only #16

jobara opened this issue Dec 10, 2020 · 0 comments
Labels

Comments

@jobara
Copy link
Member

jobara commented Dec 10, 2020

Describe the bug

While the username requirements are now configurable, a username is still required to unlock users. In the storytelling tool we are using the e-mail address for the username, so we don't actually need the username property at all. However, this function assumes the username based on how it parses the response from the call to that.byUsernameOrEmailReader.get.

Expected behavior

Because the searching for users handles lookup by username or email, unlocking should support both. Perhaps there is more general way to determine if the body returned contains the necessary data; which would allow more flexibility if the byUsernameOrEmailReader subcomponent is modified.

@jobara jobara added the bug label Dec 10, 2020
the-t-in-rtf added a commit to the-t-in-rtf/fluid-express-user that referenced this issue Dec 11, 2020
amb26 added a commit that referenced this issue Dec 14, 2020
GH-16: Add ability to unlock user with an email address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants