From 03296de62a9f6af4d5aed30fae37a48c08fe6e38 Mon Sep 17 00:00:00 2001 From: Justin Obara Date: Tue, 9 Jun 2020 16:46:21 -0400 Subject: [PATCH] fix!: Remove udpateSettings method. BREAKING CHANGE: updateSettings invoker/method removed. Update the model via the change applier directly. --- src/js/background/chromeSettings.js | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/js/background/chromeSettings.js b/src/js/background/chromeSettings.js index e557d7c..8c8c4c4 100644 --- a/src/js/background/chromeSettings.js +++ b/src/js/background/chromeSettings.js @@ -11,7 +11,7 @@ */ /* eslint-env node */ -/* global fluid, uioPlus */ +/* global fluid */ "use strict"; @@ -36,14 +36,6 @@ fluid.defaults("uioPlus.chrome.settings", { model: { settings: "{settings}.options.defaultSettings" }, - invokers: { - // A dedicated invoker instead of declaratively setting up the model change is required to provide a default - // value for the `settings` to set. This is useful for resetting the preferences. - updateSettings: { - funcName: "uioPlus.chrome.settings.updateSettings", - args: ["{that}", "{arguments}.0"] - } - }, components: { domSettingsApplier: { type: "uioPlus.chrome.domSettingsApplier", @@ -68,8 +60,9 @@ fluid.defaults("uioPlus.chrome.settings", { reset: { target: "{that reset}.options.invokers.click", record: { - func: "{settings}.updateSettings", - args: ["{settings}.options.defaultSettings"] + changePath: "{settings}.model.settings", + value: "{settings}.options.defaultSettings", + source: "reset" } } } @@ -78,10 +71,6 @@ fluid.defaults("uioPlus.chrome.settings", { } }); -uioPlus.chrome.settings.updateSettings = function (that, settings) { - that.applier.change("settings", settings || that.options.defaultSettings); -}; - fluid.defaults("uioPlus.chrome.settingsContextPanel", { gradeNames: ["uioPlus.chrome.contextMenuPanel"], strings: {