Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unloading Solver status from other CRD's info #107

Closed
fracappa opened this issue Aug 30, 2024 · 0 comments · Fixed by #111
Closed

Unloading Solver status from other CRD's info #107

fracappa opened this issue Aug 30, 2024 · 0 comments · Fixed by #111
Assignees
Labels
enhancement Improvements or request medium priority Medium priority issue question Further information is requested

Comments

@fracappa
Copy link
Contributor

fracappa commented Aug 30, 2024

Hello folks.

We recently received feedback about some misbehavior within the Solver controller.

One of this, can be found in one of this repo issue.

I believe that this is due to the complexity of the Solver status which is currently holding a lot of information on which its controller reconciles.

I specifically refer to the following info from Solver status:

  • ReserveAndBuy
  • Peering
  • DiscoveryPhase
  • ReservationPhase
  • ConsumePhase
  • Allocation
  • Contract
  • Credentials

I have the feeling we hold a lot of redundant data in here. For example, why do we have both ReserveAndBuy and ReservationPhase? They look like they have similiar info.

Moreover, I would not put other CRD's info and status in here as they have their own info which could be obtained outside the Solver (Allocation, Contract and Credentials).

Looking forward for any of your feedback.

Thanks,
Francesco

@fracappa fracappa added enhancement Improvements or request question Further information is requested medium priority Medium priority issue labels Aug 30, 2024
@fracappa fracappa linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or request medium priority Medium priority issue question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants