-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC21/27: should priorities be 0-LONGLONGMAX-1? #282
Comments
I'll just note that there's no reason the range has to match the type. We could still specify 0-UINT32_MAX (or 0-2^48 |
summarizing comments from here & flux-framework/flux-core#3428 keep things as they are now, defining priority in the range 0 - 2^32-1, there can be implementation ambiguity. We could:
|
if I had to vote on the 3 above, I'd say lets go with the second option. Don't like the idea of defining a storage requirement, and we don't have a need for |
I no longer have an opinion on this one. Status quo is fine by me, and as @grondo points out, independent of representation. |
Per discussion in flux-framework/flux-core#3428
The current priority range is 0 - 4294967295 (i.e. 0 to UINT32 MAX).
Some JSON libraries such as jansson may not support encoding of unsigned integers, only signed integers. So having a range of 0 to UINT32 MAX can be inconvenient at times.
Consider extending the range from 0 to LONGLONG_MAX (i.e. INT64 MAX or 2^62-1), so that 64 bit signed ints can be used everywhere for convenience.
The text was updated successfully, but these errors were encountered: