Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Flyteadmin notifications: use webhooks APIs #2317

Open
2 tasks done
katrogan opened this issue Apr 4, 2022 · 4 comments
Open
2 tasks done

[Core feature] Flyteadmin notifications: use webhooks APIs #2317

katrogan opened this issue Apr 4, 2022 · 4 comments
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service

Comments

@katrogan
Copy link
Contributor

katrogan commented Apr 4, 2022

Motivation: Why do you think this is important?

Currently flyteadmin notifications are delivered using the PagerDuty, Github and Slack email APIs. On AWS deployments FlyteAdmin uses SES to trigger emails, for all others the only alternative email implementation is SendGrid integration.

Setting up SES or SendGrid can be somewhat complicated. Furthermore, asking your Flyte users to configure the aforementioned services with email integrations adds even more overhead. It would be simpler as an alternative to provide webhook integration for notification so that users only have to configure existing API keys for PagerDuty/Github/Slack

Goal: What should the final outcome look like, ideally?

Setting up a flyteadmin deployment to send notifications should require simple configuration.

Describe alternatives you've considered

The current email API integration. We could introduce other email integrations to increase the accessibility of notifications.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers flyteadmin Issue for FlyteAdmin Service labels Apr 4, 2022
@flixr
Copy link
Contributor

flixr commented Jan 12, 2023

We are running flyte on-prem, and hence cannot use any of the existing notifications.
Webhooks would indeed be very nice, then we could just post it in our mattermost channel.

@pingsutw pingsutw removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 12, 2023
@BroderPeters
Copy link

We would also love to have more flexibility in the notification setup 👍🏻

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Dec 18, 2023
@marrrcin
Copy link
Contributor

It's crazy that we're in 2025 and the only option is still sending emails, which - as the author of this issue stated:

Setting up SES or SendGrid can be somewhat complicated

I totally agree on! There is a lot of overhead with domain verifications and so on, just to send a piece of text.

At least support for Slack webhooks would be nice 🙄
https://api.slack.com/messaging/webhooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service
Projects
None yet
Development

No branches or pull requests

5 participants