Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flyte Propeller does not have readiness/liveness checks #6207

Open
2 tasks done
Sovietaced opened this issue Feb 2, 2025 · 0 comments
Open
2 tasks done

[BUG] Flyte Propeller does not have readiness/liveness checks #6207

Sovietaced opened this issue Feb 2, 2025 · 0 comments
Assignees
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@Sovietaced
Copy link
Contributor

Describe the bug

When deploying a new version of Flyte Propeller it's quite easy for Flyte Propeller to get into a bad state if there is an issue during initialization of Flyte Propeller (either due to an issue with Flyte Propeller binary or the configuration of Flyte Propeller). The reason for this is because there are no readiness/liveness checks to indicate that Flyte Propeller is healthy so Kubernetes will promote the new version of Flyte Propeller as long as the container runs.

I personally encountered this while configuring some of our own plugins.

Expected behavior

Ideally Flyte Propeller should only be marked as ready by Kubernetes once it has completed initialization and hasn't encountered any issues.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Sovietaced Sovietaced added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Feb 2, 2025
@Sovietaced Sovietaced self-assigned this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant