Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: @canutin/svelte-currency-input inconsistent behavior when "page.keyboard.type" #138

Closed
fmaclen opened this issue Oct 27, 2022 · 1 comment
Closed

Tests: @canutin/svelte-currency-input inconsistent behavior when "page.keyboard.type" #138

fmaclen opened this issue Oct 27, 2022 · 1 comment
Labels
bug Something isn't working SvelteKit Involves SvelteKit's code tech debt Tasks that aim to make the codebase more maintainable

Comments

@fmaclen
Copy link
Owner

fmaclen commented Oct 27, 2022

Tests that rely on page.keyboard.type tend to fail because of how @canutin/svelte-currency-input works.
This might be fixable by implementing debouncing, but more testing is needed.
@fmaclen fmaclen added bug Something isn't working SvelteKit Involves SvelteKit's code labels Oct 27, 2022
@fmaclen fmaclen added this to the Next up milestone Oct 27, 2022
@fmaclen fmaclen added the tech debt Tasks that aim to make the codebase more maintainable label Oct 27, 2022
@fmaclen fmaclen removed this from the Next up milestone Nov 1, 2022
@fmaclen
Copy link
Owner Author

fmaclen commented Aug 25, 2023

Fixed in #181

@fmaclen fmaclen closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working SvelteKit Involves SvelteKit's code tech debt Tasks that aim to make the codebase more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmaclen