waitForAcceptance bug

[wms2537]

Describe the bug
the current implementation only waits for execution status, instead it should wait for finality status. The description is correct, but the implementation is wrong.

https://github.com/focustree/starknet.dart/blob/37d0192351ad57632a6a9933530e2b3b69c39fb4/packages/starknet/lib/src/util.dart#L120C1-L142C2

[ptisserand]

If execution_status is SUCCEEDED it means that finality_status is either ACCEPTED_ON_L2 or ACCEPTED_ON_L1
https://docs.starknet.io/architecture-and-concepts/network-architecture/transaction-life-cycle/

So I think implementation is correct but description is not fully correct.
What do you think @wms2537 ?

[wms2537]

I think there is still a slight delay between SUCCEEDED and ACCEPTED_ON_L2 right? Some problems might arise when we are executing multiple transactions together that depend on one another sequentially.

If the term acceptance is being used, I suppose it is referring to finality_status?

[ptisserand]

Yes you are right, waitForAcceptance should check finality_status instead.