Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googlefonts/STAT/compulsory_axis_values] does not run #4982

Open
simoncozens opened this issue Jan 29, 2025 · 0 comments
Open

[googlefonts/STAT/compulsory_axis_values] does not run #4982

simoncozens opened this issue Jan 29, 2025 · 0 comments

Comments

@simoncozens
Copy link
Collaborator

Observed behaviour

I wanted to see how this check works because something about it looks fishy:

is_italic = any(a.axisTag in ["ital", "slnt"] for a in ttFont["fvar"].axes)
missing_ital_av = any("Italic" in r["Name"] for r in table)

(I feel like we're missing a not in the second row.)

But actually it doesn't work at all. fontbakery check-googlefonts -c googlefonts/STAT/compulsory_axis_values Bitter\[wght\].ttf --succinct runs no checks

Expected behaviour

It should run a check.

This is not working because it declares "expected_font_names" as a condition:

conditions=["is_variable_font", "expected_font_names"],

However, as the documentation puts it:

# Note that this is not a condition!
def expected_font_names(ttFont, ttFonts):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant