Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haml upgrade breaks deface #980

Closed
Viehlieb opened this issue Feb 23, 2023 · 2 comments · Fixed by #1003
Closed

haml upgrade breaks deface #980

Viehlieb opened this issue Feb 23, 2023 · 2 comments · Fixed by #1003
Milestone
4.8

Comments

@Viehlieb
Copy link
Contributor

We found out that haml >= 6.0 breaks the plugins capabilities to alter views.
The deface gem depends on haml, but apparently does not work with haml >= 6.0. No Error thrown, but no functionality given. The documentation says it should work with haml.

Alterations that have been done inside plugin's engine.rb, e.g. add another NavItem work regardless. Only .deface files are problemativ.

suggested solution
downgrade haml to 5.X and deface will work again
@yksflip yksflip moved this to Prioritised in Foodsoft roadmap Mar 5, 2023
@github-project-automation github-project-automation bot moved this from Prioritised to Done in Foodsoft roadmap Mar 29, 2023
@kidhab
Copy link
Contributor

kidhab commented Mar 29, 2023

Reopening.
Sorry, my comment at the other repository closed this issue automatically.

@kidhab kidhab reopened this Mar 29, 2023
@kidhab
Copy link
Contributor

kidhab commented Mar 29, 2023

Issue at deface issue tracker.

@wvengen wvengen moved this from Done to Prioritised in Foodsoft roadmap Apr 26, 2023
@yksflip yksflip moved this from Prioritised to Next Release in Foodsoft roadmap Jun 9, 2023
@yksflip yksflip added this to the 4.8 milestone Jun 9, 2023
@yksflip yksflip moved this from Next Release to In Progress in Foodsoft roadmap Jun 9, 2023
@yksflip yksflip mentioned this issue Jun 9, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Foodsoft roadmap Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Foodsoft roadmap
Archived in project
Milestone
4.8
Development

Successfully merging a pull request may close this issue.

downgrade haml to make deface work foodcoops/foodsoft
3 participants
@yksflip @Viehlieb @kidhab