From cca1cdd401a6283e9a5f8e6adf4567a7c7eaea24 Mon Sep 17 00:00:00 2001 From: Cerber Date: Fri, 7 Feb 2014 16:49:12 +0100 Subject: [PATCH] Fixed ressource leak in load() --- .../redhat/openshift/forge/OpenShiftConfiguration.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/redhat/openshift/forge/OpenShiftConfiguration.java b/src/main/java/com/redhat/openshift/forge/OpenShiftConfiguration.java index 2f0d8e7..0967c62 100755 --- a/src/main/java/com/redhat/openshift/forge/OpenShiftConfiguration.java +++ b/src/main/java/com/redhat/openshift/forge/OpenShiftConfiguration.java @@ -35,7 +35,13 @@ private enum Key { public void load() { rhcProperties = new Properties(); try { - rhcProperties.load(new FileReader(EXPRESS_CONF)); + FileReader reader = null; + try { + reader = new FileReader(EXPRESS_CONF); + rhcProperties.load(reader); + } finally { + reader.close(); + } ShellMessages.info(out, "Loaded OpenShift configuration from " + EXPRESS_CONF); } catch (Exception e) { // Swallow