Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Separate ERC223 contract #3

Open
JonathonDunford opened this issue Mar 5, 2018 · 0 comments
Open

Separate ERC223 contract #3

JonathonDunford opened this issue Mar 5, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@JonathonDunford
Copy link
Contributor

So, ERC223 brought about a new transfer function that cuts the gas necessary in half.

However, we can't bundle both ERC20's old transfer methods and ERC223's new transfer as solidity doesn't allow us to check what type the requested token is AFAIK.

The current smart_contract.sol in this repo "supports" ERC223 by using a fallback, but it still goes through approve and transferFrom .

I propose that, for future proofing, we create some sort of system where each protocol (ERC20, ERC223) can have a separate contract. Then, the interface calls the contracts based on the type of token. That way, we can utilize each protocol's benefits. This would also allow us to add future protocols with ease as we would simply create a new contract for the protocol instead of editing an old one.

This is not necessary NOW, but would be a welcome addition in the future.

@JonathonDunford JonathonDunford added the enhancement New feature or request label Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant