-
Notifications
You must be signed in to change notification settings - Fork 39
Stable release - any requests? #4
Comments
Awesome Library!! Thank you for your hard work! Is there a way to add the label to the slider, datepicker and radio? Right now, I am adding custom labels using a wrapper but it is not working as I wished. This is how I am doing it: formlyConfigProvider.setWrapper({
name: 'radioLabel',
types: ['radio'],
template: '<p class="formly-label">{{to.label}}</p>' +
'<div flex><formly-transclude></formly-transclude></div>'
}); in my css:
|
@younessassassi So basically, you want the label to be available in all types. In angular-material, there is no label directive for slider, datepicker and radio so it would be an "extra" css, just for angular-formly-templates-material. I'm going to think about it between Christmas and New Year's Eve |
I have noticed that these widgets were missing the label directive in the angular material docs, and that is why I attempted to create my own. In practical terms, all input fields should be treated the same way. In my case, I would like my app users to be able to pick between different input types to generate a form so I have to provide the label for all the input types they have access to. Have a happy holidays! |
Is the 'step' attribute for numerical inputs available? (see last example of 'donation amount' input on this page https://material.angularjs.org/latest/demo/input ) Edit-- I made a pull request #6 that includes passing the |
@sgwatgit No, step attribute for numerical inputs are not yet available. |
@younessassassi I'm going to do something about labels you mentioned in few days after New Year's Eve. |
@younessassassi I added label as a wrapper to slider, datepicker and radio as you wanted. This change is available in latest release (v0.13.0). https://github.com/formly-js/angular-formly-templates-material/releases/tag/v0.13.0
|
That is awesome! I will go check it out! |
Awesome work @kamilkisiela !! Thanks ! |
@TeChn4K thanks! :) |
@kamilkisiela Do you have any roadmap to the next releases ? What's your plan ? :) |
I am starting to use ng-messages, and I noticed that the date picker does not work with that out of the box. I had to add a validator expression as well as some css to get to work. It would be nice if it did not require the manual intervention. |
@younessassassi I'm going to look at it in few days :) |
@younessassassi I think it is a angular-material issue. As you can see here. The problem is that Try to click on placeholder, it won't work because Here's funny part! I created also reproduction of this in angular-formly-material-templates. http://codepen.io/kamilkisiela/pen/KVyxqx EDIT: There is an open issue in angular-material angular/material#6598 |
Thank you @kamilkisiela. I hope the Angular Material team adds the fix soon. |
Hi, Now a technical one specific to formly-material about SELECT First, defaultValue is not working or am I missing something, could you provide a quick example if it does work ? Second, I think that when multiple is false and that selection occurs, the list should collapse to make selection feel more natural. Again thank you very much for this amazing tool <3 |
hi @kamilkisiela, how do you set a theme for the material component? Your documentation shows that you can set a theme for each field, but I was not able to get it to work. Is there an example somewhere that I can follow? |
I've made separate issues for your questions. |
Hi @kamilkisiela , First of all I'm new in formly material. Do you have any idea how I can build the multi select drop down? Currently I think it is not supported yet and I've tried modify using the formlyConfig but not able to do it. Could you please advise? |
Hi, I find myself in a situation where I need to create {
type: "radio",
key: "name",
templateOptions: {
label: "Name",
theme: "custom",
labelProp: "firstName",
valueProp: "id",
options: [
{firstName: "Sarah", id: 1},
{firstName: "Jessica", id: 2},
{firstName: "Parker", id: 3}
]
}
} formly-bootstrap templates has Can such feature be added to formly-material..? I ended up copying the multicheckbox from bootstrap material template and adding it as a custom type. |
Hi, angular material adds a |
@tilwinjoy Currently I don't have time to keep adding new features to formly-material. I will be very happy if someone, maybe you can create a PR for it. |
Hi @kamilkisiela, |
Hello Guys |
I think most of stuff from angular-material that is useful in forms is now supported by formlyMaterial.
Code is now fully covered. I recently added few more tests to accomplish that. In few days, I'm going to add a demo app with basic examples, maybe with live reload.
Has anyone any requests? Maybe I've forgot about something that has to be done.
@stefanmeschke do you need something to improve or change before stable version will be released?
TODO:
ngPattern
ininput
showError
The text was updated successfully, but these errors were encountered: