From acf5b5993870356b8bb03fa51045d449bf2511b8 Mon Sep 17 00:00:00 2001 From: mr Date: Tue, 9 Feb 2021 19:41:23 +0900 Subject: [PATCH 1/5] Fix typo --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7ea9044d9..14c7de7e7 100644 --- a/README.md +++ b/README.md @@ -320,7 +320,7 @@ const count = 2 // it tries to run 2(), but 2 is not a function (function doSomething() { // do something amazing }()) -// put a semicolon before the immediate invoked function, after the const definition, save the return value of the anonymous function to a variable or avoid IIFEs alltogether +// put a semicolon before the immediate invoked function, after the const definition, save the return value of the anonymous function to a variable or avoid IIFEs altogether ``` 🔗 [**Read more:** "Semi ESLint rule"](https://eslint.org/docs/rules/semi) @@ -340,7 +340,7 @@ const count = 2 // it tries to run 2(), but 2 is not a function **TL;DR:** Use **_lowerCamelCase_** when naming constants, variables and functions and **_UpperCamelCase_** (capital first letter as well) when naming classes. This will help you to easily distinguish between plain variables/functions, and classes that require instantiation. Use descriptive names, but try to keep them short -**Otherwise:** Javascript is the only language in the world that allows invoking a constructor ("Class") directly without instantiating it first. Consequently, Classes and function-constructors are differentiated by starting with UpperCamelCase +**Otherwise:** JavaScript is the only language in the world that allows invoking a constructor ("Class") directly without instantiating it first. Consequently, Classes and function-constructors are differentiated by starting with UpperCamelCase ### 3.6 Code Example @@ -1296,7 +1296,7 @@ All translations are contributed by the community. We will be happy to get any h ## Steering Committee -Meet the steering committee members - the people who work together to provide guidance and future direction to the project. In addition, each member of the committee leads a project tracked under our [Github projects](https://github.com/goldbergyoni/nodebestpractices/projects). +Meet the steering committee members - the people who work together to provide guidance and future direction to the project. In addition, each member of the committee leads a project tracked under our [GitHub projects](https://github.com/goldbergyoni/nodebestpractices/projects). From b053316c96eaa617c6f05ab58b65b3e0dbb6b63f Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Tue, 9 Feb 2021 19:53:16 +0000 Subject: [PATCH 2/5] docs: update README.md [skip ci] --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 5021540be..c704d91fd 100644 --- a/README.md +++ b/README.md @@ -1561,6 +1561,7 @@ Thanks goes to these wonderful people who have contributed to this repository!
Yuta Azumi
🖋 +
andrewjbarbour
🖋 From c90d8cc099855c187e1a95a9f4cba10d9159753f Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Tue, 9 Feb 2021 19:53:17 +0000 Subject: [PATCH 3/5] docs: update .all-contributorsrc [skip ci] --- .all-contributorsrc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 3386551ec..7fb5bdf88 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1277,6 +1277,15 @@ "contributions": [ "content" ] + }, + { + "login": "andrewjbarbour", + "name": "andrewjbarbour", + "avatar_url": "https://avatars.githubusercontent.com/u/77080074?v=4", + "profile": "https://github.com/andrewjbarbour", + "contributions": [ + "content" + ] } ], "projectName": "nodebestpractices", From 6c08e7388958e79abb2cca8ad2166f2362a63671 Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Tue, 9 Feb 2021 19:55:33 +0000 Subject: [PATCH 4/5] docs: update README.md [skip ci] --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 1d301d7c4..8560035cb 100644 --- a/README.md +++ b/README.md @@ -1562,6 +1562,7 @@ Thanks goes to these wonderful people who have contributed to this repository!
Yuta Azumi
🖋
andrewjbarbour
🖋 +
mr
🖋 From e843656c49b485216299c93966aeca3e43ae232d Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Tue, 9 Feb 2021 19:55:34 +0000 Subject: [PATCH 5/5] docs: update .all-contributorsrc [skip ci] --- .all-contributorsrc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 7fb5bdf88..16623795d 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1286,6 +1286,15 @@ "contributions": [ "content" ] + }, + { + "login": "MasujimaRyohei", + "name": "mr", + "avatar_url": "https://avatars.githubusercontent.com/u/17163541?v=4", + "profile": "https://MasujimaRyohei.jp", + "contributions": [ + "content" + ] } ], "projectName": "nodebestpractices",