Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regressions in Chrome v121 #81

Open
mkrause opened this issue Jan 2, 2025 · 1 comment
Open

Visual regressions in Chrome v121 #81

mkrause opened this issue Jan 2, 2025 · 1 comment
Labels
chromatic-2025 Bugs that are blocked until Chromatic 2025 platform release.

Comments

@mkrause
Copy link
Collaborator

mkrause commented Jan 2, 2025

See: #78 (comment)

That PR apparently caused a regression in Chrome v121, which is the version used on Chromatic at the moment:

Screenshot 2024-12-30 at 18 25 29

I cannot reproduce this issue in any current browser, and just from the screenshots I have not been able to deduce the cause of this issue. It's not as simple as the icon being too large, it seems that the icon takes up the full width of the icon + title element, all the while the title text is hidden/collapsed. So the icon actually scales with the title text for some weird reason.

So this would need some investigation on an actual Chrome v121 instance. On the other hand, Chrome v121 was released in January 2024, so it's a year old by now and maybe we can ignore this as an old browser bug? Chromatic will update to a newer Chrome version in February 2025.

@mkrause mkrause added the chromatic-2025 Bugs that are blocked until Chromatic 2025 platform release. label Jan 5, 2025
@mkrause mkrause changed the title Banner visual regression in Chrome v121 Visual regressions in Chrome v121 Jan 7, 2025
@mkrause
Copy link
Collaborator Author

mkrause commented Jan 7, 2025

Bunch more stuff is broken now in Chrome v121 due to this PR which introduced round(): #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromatic-2025 Bugs that are blocked until Chromatic 2025 platform release.
Projects
None yet
Development

No branches or pull requests

1 participant