Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valgrind automation to mbedtls unit tests #132

Open
AdrianCX opened this issue Dec 14, 2020 · 0 comments
Open

Add valgrind automation to mbedtls unit tests #132

AdrianCX opened this issue Dec 14, 2020 · 0 comments

Comments

@AdrianCX
Copy link
Contributor

This is raised as response to: #128 (comment)

Goal is to have valgrind memcheck running as part of unit tests and the output parsed for any error.

Any error will be a CI failure.

mcr pushed a commit to mcr/rust-mbedtls that referenced this issue Aug 10, 2023
Gets rid of synthetic_error, and makes the various send_* methods return `Result<Response, Error>`.
Introduces a new error type "HTTP", which represents an error due to status codes 4xx or 5xx.
The HTTP error type contains a boxed Response, so users can read the actual response if they want.
Adds an `error_for_status` setting to disable the functionality of treating 4xx and 5xx as errors.
Adds .unwrap() to a lot of tests.

Fixes fortanix#128.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant