Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced "time" feature on windows causes unexpected behaviour #380

Open
exFalso opened this issue Jan 20, 2025 · 0 comments
Open

Forced "time" feature on windows causes unexpected behaviour #380

exFalso opened this issue Jan 20, 2025 · 0 comments

Comments

@exFalso
Copy link

exFalso commented Jan 20, 2025

In one of our projects we use mbedtls with time support explicitly switched off. (Context: we are deliberately verifying x509 certificates which have expired validity)

We use this project to produce python packages for various platforms, including windows. We were surprised to find that time validity checks kept failing on windows even though the feature was switched off, and it took some time to track it down to these mysterious lines:

# feature 'time` is necessary under windows
[target.'cfg(target_env = "msvc")'.dependencies]
mbedtls-platform-support = { version = "0.1", path = "../mbedtls-platform-support", features = [
"time",
] }

We worked around this with an internal fork, but we wonder why these lines are there in the first place? mbedtls seems to build fine with MBEDTLS_HAVE_TIME + MBEDTLS_HAVE_TIME_DATE undefined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant