Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organiser description and events fragment #106

Open
simarsingh24 opened this issue Jun 9, 2018 · 8 comments
Open

Add organiser description and events fragment #106

simarsingh24 opened this issue Jun 9, 2018 · 8 comments
Labels

Comments

@simarsingh24
Copy link
Member

As discussed in today's meeting
Working on it 👍

@simarsingh24
Copy link
Member Author

to be done after #4928 gets resolved on server side

@iamareebjamal
Copy link
Member

There are organizer details in event itself

@simarsingh24
Copy link
Member Author

@iamareebjamal we actually wanted it to list other events under the organiser as in EventBrite App,
for that relationship to organiser should be there in the event itself .
Or we can divide it into two PR the list of events can be added later when issue is resolved.
Views?

@iamareebjamal
Copy link
Member

It is already present on server, that's how we list stuff in Orga App

@simarsingh24
Copy link
Member Author

@iamareebjamal I am sharing a typical response of event details below

  "data": {
        "type": "event",
        "attributes": {
            "has-organizer-info": true,
            "ical-url": null,
            "organizer-description": "sahi banda hai",
            "is-sponsors-enabled": true,
            "is-map-shown": false,
            "can-pay-by-stripe": true,
            "searchable-location-name": null,
            "onsite-details": null,
            "payment-country": "india",
            "can-pay-onsite": true,
            "is-ticketing-enabled": true,
            "icon-image-url": null,
            "payment-currency": "INR",
            "location-name": null,
            "thumbnail-image-url": null,
            "code-of-conduct": "",
            "xcal-url": null,
            "pentabarf-url": null,
            "state": "published",
            "deleted-at": null,
            "created-at": "2018-03-20T02:50:25.329512+00:00",
            "name": "seminar on functional programming",
            "large-image-url": null,
            "description": "the lextire will be a great experience",
            "longitude": null,
            "can-pay-by-paypal": true,
            "ticket-url": null,
            "ends-at": "2018-03-21T05:49:00+00:00",
            "identifier": "7e426698",
            "original-image-url": null,
            "schedule-published-on": null,
            "bank-details": null,
            "starts-at": "2018-03-21T02:49:12.208000+00:00",
            "latitude": null,
            "can-pay-by-cheque": true,
            "is-sessions-speakers-enabled": true,
            "cheque-details": null,
            "organizer-name": "sridhar",
            "privacy": "public",
            "external-event-url": null,
            "is-tax-enabled": true,
            "paypal-email": null,
            "timezone": "Asia/Calcutta",
            "logo-url": null,
            "can-pay-by-bank": true
        },
        "relationships": {
            "event-sub-topic": {
                "links": {
                    "self": "/v1/events/76/relationships/event-sub-topic",
                    "related": "/v1/events/76/event-sub-topic"
                }
            },
            "sessions": {
                "links": {
                    "self": "/v1/events/76/relationships/sessions",
                    "related": "/v1/events/76/sessions"
                }
            },
            "feedbacks": {
                "links": {
                    "self": "/v1/events/76/relationships/feedbacks",
                    "related": "/v1/events/76/feedbacks"
                }
            },
            "tracks": {
                "links": {
                    "self": "/v1/events/76/relationships/tracks",
                    "related": "/v1/events/76/tracks"
                }
            },
            "event-copyright": {
                "links": {
                    "self": "/v1/events/76/relationships/event-copyright",
                    "related": "/v1/events/76/event-copyright"
                }
            },
            "microlocations": {
                "links": {
                    "self": "/v1/events/76/relationships/microlocations",
                    "related": "/v1/events/76/microlocations"
                }
            },
            "session-types": {
                "links": {
                    "self": "/v1/events/76/relationships/session-types",
                    "related": "/v1/events/76/session-types"
                }
            },
            "speakers-call": {
                "links": {
                    "self": "/v1/events/76/relationships/speakers-call",
                    "related": "/v1/events/76/speakers-call"
                }
            },
            "speakers": {
                "links": {
                    "self": "/v1/events/76/relationships/speakers",
                    "related": "/v1/events/76/speakers"
                }
            },
            "ticket-tags": {
                "links": {
                    "self": "/v1/events/76/relationships/ticket-tags",
                    "related": "/v1/events/76/ticket-tags"
                }
            },
            "social-links": {
                "links": {
                    "self": "/v1/events/76/relationships/social-links",
                    "related": "/v1/events/76/social-links"
                }
            },
            "custom-forms": {
                "links": {
                    "self": "/v1/events/76/relationships/custom-forms",
                    "related": "/v1/events/76/custom-forms"
                }
            },
            "faqs": {
                "links": {
                    "self": "/v1/events/76/relationships/faqs",
                    "related": "/v1/events/76/faqs"
                }
            },
            "tickets": {
                "links": {
                    "self": "/v1/events/76/relationships/tickets",
                    "related": "/v1/events/76/tickets"
                }
            },
            "tax": {
                "links": {
                    "self": "/v1/events/76/relationships/tax",
                    "related": "/v1/events/76/tax"
                }
            },
            "event-topic": {
                "links": {
                    "self": "/v1/events/76/relationships/event-topic",
                    "related": "/v1/events/76/event-topic"
                }
            },
            "event-type": {
                "links": {
                    "self": "/v1/events/76/relationships/event-type",
                    "related": "/v1/events/76/event-type"
                }
            },
            "sponsors": {
                "links": {
                    "self": "/v1/events/76/relationships/sponsors",
                    "related": "/v1/events/76/sponsors"
                }
            },
            "faq-types": {
                "links": {
                    "self": "/v1/events/76/relationships/faq-types",
                    "related": "/v1/events/76/faq-types"
                }
            }
        },
        "id": "76",
        "links": {
            "self": "/v1/events/76"
        }
    },
    "links": {
        "self": "/v1/events/76"
    },
    "jsonapi": {
        "version": "1.0"
    }
}

Relationship with organiser and coorganiser is not there, In orga app I guess we already have organiser id when he logs in and then we can easily get list of events under him/her still I will check how it works in orga app

@dr0pdb
Copy link

dr0pdb commented Jul 1, 2018

@simarsingh24 I don't understand the requirement here. See, the organizer can choose whether he/she wants to reveal his/her information to the public or not.
You can use event.hasOrganizerInfo to check if the info is present or not. If yes, then use event.organizerName and event.organizerDescription to get the details. As @iamareebjamal stated, they are already in the event. Check in the list of fields here: https://open-event-api-dev.herokuapp.com/#events

The organizer relationships aren't there since you are not the event organizer. We don't send all the information to everyone. The data that is sent is decided on your permissions.

@simarsingh24
Copy link
Member Author

@srv-twry thats not what we want if the organiser choose to show his information then similar to eventbrite we should show all the events published by him along with all of his details.
Please look at eventbrite app

@dr0pdb
Copy link

dr0pdb commented Jul 1, 2018

Cool, I understood the requirement but this needs to be discussed with the mentors before I can make changes to the server for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants