Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintainence] Make separate dependencies file for maintaining all dependencies/libraries #1410

Open
1 task
RotBolt opened this issue Mar 24, 2019 · 11 comments · May be fixed by #2353
Open
1 task

[Maintainence] Make separate dependencies file for maintaining all dependencies/libraries #1410

RotBolt opened this issue Mar 24, 2019 · 11 comments · May be fixed by #2353

Comments

@RotBolt
Copy link

RotBolt commented Mar 24, 2019

Describe the chore
Make a separate dependencies file to list all dependencies version number / libraries versions and reference those versions in build.gradle files

This would include dependencies.gradle file which would contain all versions of dependencies/ libraries used . This would help us in maintaining/ adding the future dependencies .

Would you like to work on the issue?

  • [ ✔️ : ] Yes
  • No
  • Other:
@RotBolt
Copy link
Author

RotBolt commented Mar 24, 2019

@iamareebjamal could you give your opinion ?

@RotBolt RotBolt changed the title [Maintainence] Make Dependencies file for maintaining all dependencies/libraries [Maintainence] Make separate dependencies file for maintaining all dependencies/libraries Mar 24, 2019
@iamareebjamal
Copy link
Member

Not all, only repeated ones

@Skrilltrax
Copy link

Skrilltrax commented Sep 17, 2019

@iamareebjamal @mariobehling is it okay to convert gradle files to kts files ? We can use buildSrc with dependencies update gradle plugin.

Here are some other benefits to this : https://medium.com/mindorks/migrating-gradle-build-scripts-to-kotlin-dsl-89788a4e383a

Medium
Howdy people! It’s bean a while since Gradle released support for Kotlin scripts. We have been writing Gradle script in a language called…

@iamareebjamal
Copy link
Member

Yes, please go ahead and share before and after build durations after ./gradlew clean

@Skrilltrax
Copy link

@iamareebjamal almost done with the kotlin dsl, the build times are as follows (benchmarked with hyperfine)

Groovy
Clean Build - 171.838s
Next Build - 13.375s

Kotlin
Clean Build - 149.667s
Next Build - 10.113s

@liveHarshit liveHarshit added this to the Codeheat 3 milestone Sep 19, 2019
@Skrilltrax
Copy link

However i had some difficulty with signingConfigs and playStoreImplementation

  1. Are signingConfig variables like SIGNING_KEY_FILE, ALIAS, KEY_ALIAS and STORE_PASS in local.properties because the gradle local properties plugin is not compatible with kotlin dsl.

  2. Is playStoreImplementation a custom config because the kotlin dsl cannot find it.

@Skrilltrax Skrilltrax linked a pull request Sep 19, 2019 that will close this issue
@iamareebjamal
Copy link
Member

  1. It is fine if it is not supported, but it is still important to load them from environment variable
  2. No it is not custom config. It's standard config defined in Android Gradle Plugin

@adityastic
Copy link
Contributor

@Skrilltrax playStoreImplementation is a flavour specifc dependency configuration

@Skrilltrax
Copy link

@iamareebjamal I'm doing both but i am not using the plugin, so should i remove it ? can you also please confirm if i should keep AndroidConfig object in the PR, I made it but then it seemed kinda overkill.

@adityastic Thanks, the dsl does not automatically recognise it so i'll be using property delegation for that.

@iamareebjamal
Copy link
Member

Remove both

@Skrilltrax
Copy link

Updated PR

@liveHarshit liveHarshit modified the milestones: Codeheat 3, Codeheat 7 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants