Solidity Scripting Tutorial code incompatible with v5 OpenZeppelin Ownable class

[frankmullenger]

The Solidity Scripting Tutorial example code doesn't compile when the latest version of the OpenZeppelin library is used.

Installing OpenZeppelin library using the instructions: forge install transmissions11/solmate Openzeppelin/openzeppelin-contracts seems to install the latest version of the OpenZeppelin library (v5), possibly because the ref defaults to "master"?

The function signature of the OpenZeppelin Ownable class has changed in v5 from v4, the constructor now requires an "initialOwner" parameter.

So the example code in the Tutorial is missing a call to the base constructor in Ownable.

The compilation error (using Solc 0.8.22) is:

Error: 
Compiler run failed:
Error (3415): No arguments passed to the base constructor. Specify the arguments or mark "NFT" as abstract.
  --> src/NFT.sol:13:1:
   |
13 | contract NFT is ERC721, Ownable {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Base constructor parameters:
  --> lib/openzeppelin-contracts/contracts/access/Ownable.sol:38:16:
   |
38 |     constructor(address initialOwner) {
   |   

Possibly the NFT constructor could call the base constructor?

constructor(
    string memory _name,
    string memory _symbol,
    string memory _baseURI
) ERC721(_name, _symbol) Ownable(msg.sender) {
    baseURI = _baseURI;
}

Or possibly the dependency could specify a version?

forge install transmissions11/solmate Openzeppelin/[email protected]

[Evalir]

We could also update the tutorial—would you be up for it @frankmullenger ?

[frankmullenger]

@Evalir Yeah I'd be happy to open a pull request for this 😃

[Evalir]

awesome! will assign to you @frankmullenger