Remove RawForgeConfig abstraction

[kkawula]

Which components does the task require to be changed? (think hard pls)

snforge

Description

Config got from Scarb.toml is stored in ForgeConfigFromScarb struct, but firstly toml is mapped into RawForgeConfig, partially validated, and then mapped into ForgeConfigFromScarb. It can be done without RawForgeConfig abstraction by implementing Deserialize Trait for ForgeConfigFromScarb, ForkTarget, and so on.

Flow that should be refactored:

starknet-foundry/crates/forge/src/scarb.rs

Lines 26 to 31 in 3d857eb

	let raw_config = serde_json::from_value::<RawForgeConfig>(config.clone())?;
	raw_config
	.try_into()
	.context("Invalid config in Scarb.toml: ")
	}

Validation for ForkTarget that should be implemented in the deserialize method:

starknet-foundry/crates/forge/src/scarb/config.rs

Lines 91 to 115 in 3d857eb

	fn validate_raw_fork_config(raw_config: RawForgeConfig) -> Result<RawForgeConfig> {
	let forks = &raw_config.fork;
	let names: Vec<_> = forks.iter().map(|fork| &fork.name).collect();
	let removed_duplicated_names: HashSet<_> = names.iter().collect();
	if names.len() != removed_duplicated_names.len() {
	bail!("Some fork names are duplicated");
	}
	for fork in forks {
	let block_id_item = fork.block_id.iter().exactly_one();
	let Ok((block_id_key, block_id_value)) = block_id_item else {
	bail!("block_id should be set once per fork");
	};
	if !["number", "hash", "tag"].contains(&&**block_id_key) {
	bail!("block_id = {block_id_key} is not valid. Possible values are = \"number\", \"hash\" and \"tag\"");
	}
	if block_id_key == "tag" && block_id_value != "latest" {
	bail!("block_id.tag can only be equal to latest");
	}
	}

ForkTarget::new should be replaced, by creation from deserializing json.