Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include snippet related to conditional compilation in documentation listings #2515

Open
integraledelebesgue opened this issue Sep 25, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation scarb snforge

Comments

@integraledelebesgue
Copy link
Member

Which component is the issue related to?

Foundry Book

Issue

At the moment, code from docs/listings/snforge_advanced_features/crates/conditional_compilation/src/function.cairo is not being tested. Line declaring it as a module is commented.

Even though both function and its test module are compiled conditionally, compilation fails with an error:

error: Function not found.
 --> [...]/starknet-foundry/docs/listings/snforge_advanced_features/crates/conditional_compilation/src/function.cairo:9:1
    #[test]
^*********^

@maciektr explained that a bug in Scarb causing this has been solved here.

We need to include this file as soon as Foundry starts using newer Scarb in the future.

@integraledelebesgue integraledelebesgue converted this from a draft issue Sep 25, 2024
@integraledelebesgue integraledelebesgue moved this from TODO to New in Starknet foundry Sep 25, 2024
@github-actions github-actions bot added the new label Sep 25, 2024
@integraledelebesgue integraledelebesgue moved this from New to TODO in Starknet foundry Sep 25, 2024
@integraledelebesgue integraledelebesgue added bug Something isn't working documentation Improvements or additions to documentation scarb labels Sep 25, 2024
@cptartur cptartur removed the new label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation scarb snforge
Projects
Status: Backlog
Development

No branches or pull requests

2 participants