Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account delete command #2520

Closed
kkawula opened this issue Sep 26, 2024 · 0 comments · Fixed by #2539
Closed

Fix account delete command #2520

kkawula opened this issue Sep 26, 2024 · 0 comments · Fixed by #2539
Assignees
@kkawula
Labels
bug Something isn't working new sncast

Comments

@kkawula
Copy link
Collaborator

kkawula commented Sep 26, 2024

Which components does the task require to be changed? (think hard pls)

sncast

Description

Command account delete requires url, but it should be optional as written in the docs
@kkawula kkawula added bug Something isn't working sncast new labels Sep 26, 2024
@cptartur cptartur moved this from New to Backlog in Starknet foundry Sep 30, 2024
@kkawula kkawula mentioned this issue Oct 1, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@kkawula @cptartur
Fix 'account delete' command (#2539)
e2519c6 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2520

## Introduced changes

<!-- A brief description of the changes -->

- Made `--url` argument optional 

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Artur Michałek <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
bug Something isn't working new sncast
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'account delete' command foundry-rs/starknet-foundry
1 participant
@kkawula