-
Notifications
You must be signed in to change notification settings - Fork 117
Split Compressors into request / accept compressions. #102
Comments
@sschepens thoughts? |
Hmm, Of course It's doable and shouldn't be difficult, I just don't see any real gain, but of course if this is preventing someone from using |
No, neither wget nor curl do compression on request. They only add |
We spoke about this with @sschepens and came to the conclussion of disabling request compression by default when @j16sdiz @sschepens does that work for you? |
@j16sdiz request compression is necessary when batch-sending data to a service such as elasticsearch for example. @marcosnils yes, this is ok for me, as long as it's possible to turn on request compression it's ok. |
The default go http transport add "Accept-Encoding: gzip" and do transparent decompression if you don't specify any Accept-Encoding. See |
Transparent compression on request and decompression on response should be two independent options.
Currently, the
Accept-Encoding: gzip
andContent-Encoding: gzip
are both controlled by theCompression
option.A survey of desktop browsers found none of them are sending gzipped content in request, but all of them are accepting gzipped content in response. PHP, Apache and Nginx have build-in constructs to do gzip on response. Only Apache can do decompression on request.
To have maximum compatibility, two options should be controlled separately.
The text was updated successfully, but these errors were encountered: