goreq.Request.Timeout behavior is different from http.Client.Timeout

[defia]

http://play.golang.org/p/Fjv_Bf_UyH
hangs on ioutil.ReadAll

http://play.golang.org/p/TsXX5MyMC4
timeout works.

we have to override goreq.DefaultClient to set timeout flawlessly

[sschepens]

It seems to me that this happens because we wrap Body in our own object and we're not closing it on faliure, should be easy to fix.

[sschepens]

Ok, this is a little more complicated, goreq stops the timer when request is answered, it doesn't care about the request body. I have to check what go does in this case, maybe we could set read timeout to that value or make timer stop when request body is closed.
We would need to replicate this behaviour: https://golang.org/src/net/http/client.go#L530

[sschepens]

I'll see if I have time on the weekend to get this done

[marcosnils]

@defia this should be fixed in the latest goreq. Can you please check?