Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monochrome icons that don't follows plasma color scheme #73

Open
Tichy opened this issue Mar 23, 2018 · 12 comments
Open

Monochrome icons that don't follows plasma color scheme #73

Tichy opened this issue Mar 23, 2018 · 12 comments
Assignees

Comments

@Tichy
Copy link

Tichy commented Mar 23, 2018

I know that you are redrawing all monochrome icons to reflect the color scheme in plasma. By changing my theme to a darker one, I found some of them in the old style, that were harder to spot with a light theme.
screenshot_20180323_211019
Ark, Redshift

screenshot_20180323_211045
Gwenview, Libreoffice Draw, Okular

screenshot_20180323_211106
Konversation, Qbittorrent(?)

screenshot_20180323_211153
Cool retro term, kinfocenter, ksystemlog, kwalletmanager, k3b

screenshot_20180323_211232
All libreoffice applications

screenshot_20180323_211244
All session icons

Also, some sizes of the telegram icon
screenshot_20180323_222204

@Tichy
Copy link
Author

Tichy commented Mar 28, 2018

Hi, sorry for not noticing them earlier. I found these on my other machine with different software.

Two more of them:
preferences-desktop-user-password
akonadiconsole

@Tichy
Copy link
Author

Tichy commented Mar 28, 2018

I found more of them using kmail with a dark theme
screenshot_20180328_194240
server(?), inbox, sent, outbox

screenshot_20180328_194332
Open recent, Import, print preview, check mail, send

screenshot_20180328_194402
new folder, mark as read

screenshot_20180328_194430
reply, reply to all, move to...

screenshot_20180328_194505
OT: The certificates management (which launches kleopatra) isn't monochrome

screenshot_20180328_194528
notifications settings

screenshot_20180328_194553
the "what is?", (maybe) the option to notify a bug

@franksouza183 franksouza183 reopened this Mar 28, 2018
@Tichy
Copy link
Author

Tichy commented Mar 29, 2018

Looking at kate:
screenshot_20180329_144524
the documents icon, the file icon, maybe the kate monochrome icon also?

screenshot_20180329_144548
print preview, export

screenshot_20180329_144621
redo, select all

screenshot_20180329_144646
new window, up, down, left(prev), right(next), quick open, zoom in and out

screenshot_20180329_144723
full screen

screenshot_20180329_144736
quick open. also, all split icons seems to fallback on brezze

screenshot_20180329_144751
find and replace

@franksouza183
Copy link
Owner

franksouza183 commented Mar 30, 2018

the documents icon, the file icon, maybe the kate monochrome icon also?

Some icons already have kde monochrome support, the problem is on the title bar/tabs that don't works how it should, or maybe you just need to re-choose Evolvere on systemsettings, then restart.

allgood

@Tichy
Copy link
Author

Tichy commented Apr 1, 2018

Found some more in gwenview, qbittorrent and konversation

screenshot_20180401_111916
rotate left / right, flip horizontal / vertical

screenshot_20180401_111946
fullscreen, 1:1 zoom

screenshot_20180401_112052
top, bottom

screenshot_20180401_112121
that door icon(?)

screenshot_20180401_112227
close tab, url, log

screenshot_20180401_112301
that pencil icon

@Tichy
Copy link
Author

Tichy commented Apr 3, 2018

from konsole
screenshot_20180403_183048
clone tab

from dolphin
screenshot_20180403_183235
show in groups(?)

plasma desktop context menu
screenshot_20180403_183327
refresh desktop, activities

from k3b
screenshot_20180403_183622
eject

@franksouza183
Copy link
Owner

Again, always re-choose Evolvere and restart the app (including plasmashell), some of these icons already done.

@franksouza183
Copy link
Owner

The outline color is set to the background color, not the background color of the selection, maybe that's why, sometimes, you're see dark parts. This will be "fixed" once all the monochrome icons have been migrated, then, with the script, the outlines can be fully transparent, keeping visible only the text color.

@Tichy
Copy link
Author

Tichy commented Apr 4, 2018

I thought of a better way to find all monochrome icons that don't use the colour-scheme colours, without having to spot them at sight. Just launch this grep in the main icons folder. It searches for all files that doesn't contain the string "ColorScheme" or "currentColor" (case insensitive). There will be duplicates, because it lists all symlinks too.

grep -R -L -i 'ColorScheme\|currentColor' {8x8,10x10,12x12,16x16,18x18,20x20,22x22,24x24}

I don't know if you already have a list of all them, but I thought it could be handy and surely less annoying than me adding a comment every time I found some 😉

@franksouza183
Copy link
Owner

franksouza183 commented Apr 4, 2018

This is very useful, thank you!. Right now I'm optimizing all small icons by hand (if you know any way to do this in batch, would be extremely useful), then apply, via script, the monochrome support.

@Tichy
Copy link
Author

Tichy commented Apr 5, 2018

If it's a simple string substitution or something that can be done from the CLI, I could try to make a script.

edit: I just found that, but never tried it: https://github.com/svg/svgo

@franksouza183
Copy link
Owner

Perfect! Thank you!

@franksouza183 franksouza183 self-assigned this Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants