Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why the $pidBasket here? #44

Open
TrueType opened this issue Mar 9, 2019 · 1 comment
Open

why the $pidBasket here? #44

TrueType opened this issue Mar 9, 2019 · 1 comment

Comments

@TrueType
Copy link
Contributor

TrueType commented Mar 9, 2019

$pidBasket = ($this->conf['PIDbasket'] ? $this->conf['PIDbasket'] : $TSFE->id);

It is still used further down. But it's a code smell to have it as left-over from older usage at this position.

@franzholz
Copy link
Owner

It should have been possible, to only have a basket page in the shop and no info, no payment and no finalize page. All codes are executed on the basket page. However the other url markers are still needed, because they are used in the example templates.

However this line seems to be wrong:

$pid = ($this->conf['PID' . $command] ? $this->conf['PID' . $command] : $pidBasket);

There should better be a test if it is a valid integer value. An unset PIDpayment would have the value {$plugin.tt_products.PIDpayment} , because TYPO3 does not resolve empty values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants