Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench new-site, Should it set up the database? should this be job of bench migrate command? #1571

Open
ysaakpr opened this issue Jul 24, 2024 · 0 comments
Labels

Comments

@ysaakpr
Copy link

ysaakpr commented Jul 24, 2024

As of now, if i create a new site, i could see that its creating a underlying data bases and also installing the frappe components and its related databases.

I feel from a initial setup point it looks corrects.

But from a repeatable build perspective i feel, new-site must just create the necessary assets and configurations to the sites folder.
I would recommend the bench migrate command to perform the applying of changes to the end system. Which gives the ability to configure the configurations with different parameters and can check the real status on the connected parameters and do the database related initializations.

The benefits of the same would be, while dockerizing the final app, i could do the site generation, related assets files during a build stage, but ignore any database requirements at the build stage, and while deploying, i can do a migrate as typical we do any other apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant