Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target-dir parameter to get-app #1572

Open
pgreenwo opened this issue Jul 27, 2024 · 0 comments
Open

Add --target-dir parameter to get-app #1572

pgreenwo opened this issue Jul 27, 2024 · 0 comments

Comments

@pgreenwo
Copy link

pgreenwo commented Jul 27, 2024

Issue: Feature Request

Is your feature request related to a problem? Please describe.

When installing the Raven chat app with bench, I discovered that my install was failing because of the capitalisation in the Raven repo name, which was used for the target directory name. The yarn install process looked for an uncapitalised directory name.

A git clone CLI command would have allowed me to fix this in the CLI instruction by specifying the target, but using bench meant that this option wasn't available.

Describe the solution you'd like

Be able to do this:

bench get-app raven https://github.com/The-Commit-Company/Raven.git --target-dir /workspace/development/frappe-bench/apps/raven

Describe alternatives you've considered

  1. Forking the repo and renaming it to lower case.
  2. Forking the repo and adjusting the installation location parameters.
  3. Modifying yarn to make it case insensitive.

Additional context

@pgreenwo pgreenwo changed the title Add --target-dir /workspace/development/frappe-bench/apps/raven Add --target-dir parameter to get-app Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant