Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Rate Fetch Issue #43491

Open
chanyork opened this issue Oct 2, 2024 · 2 comments
Open

Exchange Rate Fetch Issue #43491

chanyork opened this issue Oct 2, 2024 · 2 comments
Labels

Comments

@chanyork
Copy link

chanyork commented Oct 2, 2024

Information about bug

image

Module

other

Version

15.37.0
15.43.0

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

@chanyork chanyork added the bug label Oct 2, 2024
@jukkis69
Copy link

jukkis69 commented Oct 6, 2024

I have the same issue with, cannot get exchange rate (was working couple of years without an issue)
ERPNext: v14.29.1 (version-14)
Frappe Framework: v14.40.1 (version-14)

image

Strangely error message says URL to be: https://frankfurter.dev/2024-10-06?base=USD&symbols=INR which does not work manually doing query.

However if you manually copy the example query "https://api.frankfurter.app/2023-03-28?base=USD&symbols=INR" you will get the reply {"amount":1.0,"base":"USD","date":"2023-03-28","rates":{"INR":82.15}} --> so the Frankfurther app is working. My currencies are GBP --> USD, so they also work in manual query.

Wonder where the issue might be?

Also if I use exchangerate.host, it complains about ACCESS_KEY.
I have got one, but there seems to be no way to add the ACCESS_KEY to the request query parameters? At least do not seem to figure way to add this.

image

@jukkis69
Copy link

jukkis69 commented Oct 7, 2024

Ok I updated my versions to latest
ERPNext: v14.74.3 (version-14)
Frappe Framework: v14.81.6 (version-14)
And exchange rate error went away - so maybe fix along the line - or just needed resetting some properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants