Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Preset blocks default config inconsistently #125

Open
this-gavagai opened this issue Feb 7, 2024 · 0 comments
Open

[bug] Preset blocks default config inconsistently #125

this-gavagai opened this issue Feb 7, 2024 · 0 comments

Comments

@this-gavagai
Copy link

frappe-ui includes a preset config file to align tailwindcss's defaults to the frappe design language. That's great. At present, however, the logic of the file is a bit strange. It extends the defaults for some classes (spacing, width, height, minWidth, minHeight, borderColor, typography) but replaces them for others (colors, borderRadius, boxShadow, container, fontSize, screens).

It is not clear whether this was deliberate, but it can lead to a very confusing experience for users. Some tailwind classes are blocked, while others pass through. The fix is easy, and I'm happy to submit a PR, but I am posting an issue first in case the maintainers have any opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant