Stripe Checkout Failure Unknown column 'payment_plan' in 'field list'

[littletuna4]

On a fresh install of the payments app, my Stripe checkout isn't working :(

Description:

In short the payment_plan field isn't found?

Investigation

I can't fully discern how it's supposed to work from an inspection of the codebase

It's breaking at the checkout:

payments/payments/templates/pages/stripe_checkout.py

Line 44 in f84edf9

context.reference_doctype, context.reference_docname, "payment_plan"

Image of the payment request fields (no payment_plan field in it (even after bench-migration)):

But it seems the stripe settings should have the field too based on this:

payments/payments/payment_gateways/stripe_integration.py

Lines 39 to 41 in f84edf9

	for payment_plan in stripe_settings.payment_plans:
	plan = frappe.db.get_value("Subscription Plan", payment_plan.plan, "product_price_id")
	items.append({"price": plan, "quantity": payment_plan.qty})

Once again, I don't have the field in the doctype?
Image of the stripe settings fields (no payment_plan field here either):

Logs

Nothing shows up in the backend logs
Haven't been able to find anything in the db either.

Thanks for any help!

Environment:

Custom Docker Build version 15 (Apps have been super fiddly to get going, so I've made lots of changes to get things sorta working - could have easily corrupted/broken something)

Error Message:

Traceback shown in client below:

Traceback (most recent call last):
  File "apps/frappe/frappe/website/serve.py", line 18, in get_response
    response = renderer_instance.render()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 84, in render
    html = self.get_html()
           ^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/website/utils.py", line 517, in cache_html_decorator
    html = func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 95, in get_html
    self.update_context()
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 162, in update_context
    data = self.run_pymodule_method("get_context")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 224, in run_pymodule_method
    return method(self.context)
           ^^^^^^^^^^^^^^^^^^^^
  File "apps/payments/payments/templates/pages/stripe_checkout.py", line 43, in get_context
    payment_plan = frappe.db.get_value(
                   ^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 509, in get_value
    result = self.get_values(
             ^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 606, in get_values
    out = self._get_values_from_table(
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 835, in _get_values_from_table
    return query.run(as_dict=as_dict, debug=debug, update=update, run=run, pluck=pluck)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/query_builder/utils.py", line 87, in execute_query
    result = frappe.db.sql(query, params, *args, **kwargs)  # nosemgrep
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 220, in sql
    self._cursor.execute(query, values)
  File "env/lib/python3.11/site-packages/pymysql/cursors.py", line 158, in execute
    result = self._query(query)
             ^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/cursors.py", line 325, in _query
    conn.query(q)
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 549, in query
    self._affected_rows = self._read_query_result(unbuffered=unbuffered)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 779, in _read_query_result
    result.read()
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 1157, in read
    first_packet = self.connection._read_packet()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "env/lib/python3.11/site-packages/pymysql/connections.py", line 729, in _read_packet
    packet.raise_for_error()
  File "env/lib/python3.11/site-packages/pymysql/protocol.py", line 221, in raise_for_error
    err.raise_mysql_exception(self._data)
  File "env/lib/python3.11/site-packages/pymysql/err.py", line 143, in raise_mysql_exception
    raise errorclass(errno, errval)
pymysql.err.OperationalError: (1054, "Unknown column 'payment_plan' in 'field list'")

[littletuna4]

I've upgraded from version-14 to version-15 and error persists.
So not looking like a versioning issue.

[demitchell14]

Running into the same issue, version-15.

I originally planned on trying to use Braintree for payments, however, subscriptions don't seem to be set up at all for it from what I read in the code, but Stripe looked like it was set up.. went to go play with it and ran into this issue as well.

I did a little digging myself earlier and it looks to me like the payment_plan directory was removed from ERPNext at some point, but was never added into the frappe/payments repo.

https://github.com/frappe/erpnext/tree/ba6f6d976d88b8bfd5ebc02e8dc33cb108b34fd5/erpnext/erpnext_integrations/doctype/payment_plan

Looking at the payment_plan.json and comparing it what subscription_plan.json originally was when it was released, to me it looks like these should be the same and this was simply missed.