Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-handled exception in unsubscribe() remote service. #12

Open
ralemy opened this issue Apr 10, 2016 · 0 comments
Open

Un-handled exception in unsubscribe() remote service. #12

ralemy opened this issue Apr 10, 2016 · 0 comments

Comments

@ralemy
Copy link

ralemy commented Apr 10, 2016

Thank you for sharing this library.

The http.request() made in unsubscribe() function, line 596 does not have a handler for error function. this means that if the remote device shuts down before the peer, there will be an un-handled exception when the local peer tries to shut down, and calls removeAllListeners().

It would be great if line 615 would have the following code:
req.on("error",function(){});

Regards,
Reza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant