Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource names not converted to correct format #48

Open
aivuk opened this issue Jul 22, 2022 · 2 comments
Open

Resource names not converted to correct format #48

aivuk opened this issue Jul 22, 2022 · 2 comments
Assignees

Comments

@aivuk
Copy link
Contributor

aivuk commented Jul 22, 2022

According to the Data Resource specifications https://specs.frictionlessdata.io/data-resource/#name a resource name:

MUST consist only of lowercase alphanumeric characters plus “.”, “-” and “_”.

Currently, if you provide a CKAN dataset to ckan_to_frictionless.py with a resource not following the above rule, the name will be written as it is, containing any character and not in lower case.

There are two options to solve the issue:

  1. Just raise an error to the user informing about the problem
  2. Convert the name to a valid one, removing invalid characters and putting in lowercase.
@aivuk
Copy link
Contributor Author

aivuk commented Jul 22, 2022

What do you think? @amercader

@amercader
Copy link
Member

I think we should follow the spec here and parse incoming CKAN resource names to make them adhere to the spec

@aivuk aivuk self-assigned this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants