Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character set of a Table's DataSourceFormat can't be set #77

Open
iSnow opened this issue Dec 5, 2022 · 0 comments · Fixed by #78
Open

Character set of a Table's DataSourceFormat can't be set #77

iSnow opened this issue Dec 5, 2022 · 0 comments · Fixed by #78

Comments

@iSnow
Copy link
Contributor

iSnow commented Dec 5, 2022

Test is TableEncodingTests::createTableFromIso8859() (currently disabled) and is an adaptation of frictionlessdata/datapackage-java#43 (as the datapackage code relies on tableschema to read resources)

The following fails:

File testDataDir = getTestsuiteDataDirectory();

Table table = Table.fromSource(new File("csv/encodings/iso8859.csv"), testDataDir, null, null);

Iterator<Object[]> iter = table.iterator();
Object[] row = iter.next();
Assertions.assertEquals("Réunion", row[0]);

What needs to be done is ensure the code in TableDataSource concrete implementations can be configured to read from different encodings.


Please preserve this line to notify @iSnow (lead of this repository)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant