Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashedSaltedValue missing from Credential representation #109

Closed
elnurvl opened this issue Jun 5, 2024 · 4 comments · Fixed by #120
Closed

hashedSaltedValue missing from Credential representation #109

elnurvl opened this issue Jun 5, 2024 · 4 comments · Fixed by #120
Assignees

Comments

@elnurvl
Copy link

elnurvl commented Jun 5, 2024

It is not straightforward to create a credential representation out of an existing bcrypt hash value due to the lack of hashedSaltedValue.

A user would need to decompose the hash manually before making a Credential representation.

@fschmtt
Copy link
Owner

fschmtt commented Jun 6, 2024

Hey, I'm out for the next 5 days, so please don't wonder when I'm not responding 😅

@fschmtt
Copy link
Owner

fschmtt commented Jun 13, 2024

Would it be sufficient to just add the missing property to the representation class?

I tried it locally, but I cannot generate a client with credentials that has the hashedSaltedValue available.

Additionally, the property is deprecated: https://www.keycloak.org/docs-api/25.0.0/javadocs/org/keycloak/representations/idm/CredentialRepresentation.html#hashedSaltedValue

What would you suggest to solve your issue? 🤔

@prajwaldivate
Copy link

Hey @fschmtt

I am looking forward to use this fix in my project. I noticed that the commit is currently on the credential-properties branch. Are there any plans to merge this into the main branch soon?

Thanks!

@fschmtt
Copy link
Owner

fschmtt commented Aug 20, 2024

Hey @prajwaldivate if you could, please verify that #120 works for you, then I'll happily merge it 🙂

@fschmtt fschmtt linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants