You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is problem with auth needed repositories, it seems that after sending username and password the pull request takes very long. As i figured out thats because reading from stderr produces that delay.
This seems not a mr.developer bug but it cold be fixed there and maybe someone is having the same error with some other vcs.
Steps to reproduce:
Private repo bitbucket or a self hosted with rhodecode with auth needed
Clone repo
Run time git pull 2>&1 | tee it should take much longer that time git pull or run the example code from this gist [1]. The output form the gist [2]
As you can see if we use tempfile the problem is solved.
So i would propose to change the code to use tempfile insted of suprocess.PIPE. Just as remark i also tried setting O_NONBLOCK flag. [3]
There is problem with auth needed repositories, it seems that after sending username and password the pull request takes very long. As i figured out thats because reading from stderr produces that delay.
This seems not a mr.developer bug but it cold be fixed there and maybe someone is having the same error with some other
vcs
.Steps to reproduce:
time git pull 2>&1 | tee
it should take much longer thattime git pull
or run the example code from this gist [1]. The output form the gist [2]As you can see if we use
tempfile
the problem is solved.So i would propose to change the code to use
tempfile
insted ofsuprocess.PIPE
. Just as remark i also tried settingO_NONBLOCK
flag. [3]Use versions:
Python 3.4.2
git version 2.1.0
Ubuntu 14.10
[1] https://gist.github.com/delijati/e1ff03c3ad40dfe225ba
[2] https://gist.github.com/delijati/10d78d4f4f681851603d
[3] http://eyalarubas.com/python-subproc-nonblock.html
The text was updated successfully, but these errors were encountered: