Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircularBuffer has no tests #16

Open
misterspeedy opened this issue Jun 4, 2014 · 4 comments
Open

CircularBuffer has no tests #16

misterspeedy opened this issue Jun 4, 2014 · 4 comments
Labels
bug help wanted 2.0

Comments

@misterspeedy
Copy link

CircularBuffer has no tests. Also it would be nice to have a comment which says how this structure differs from RingBuffer, which also exists in the codebase.
@panesofglass
Copy link

Tests were never formalized as such. They were also left in F#x in the samples: CircularBuffer.fsx. As to the nearly duplicate RingBuffer, @jackfoxy and I were supposed to sync up on that. We'll take a look next week.

TODO:

  • Move/add tests for CircularBuffer from F#x
  • Merge CircularBuffer and RingBuffer or otherwise indicate their specific uses
  • Bring this back into F#x and replace the other RingBuffer in the F#x Observable module

@panesofglass panesofglass mentioned this issue Jun 4, 2014
Closed
@jackfoxy jackfoxy added the bug label Jul 7, 2018
@jackfoxy
Copy link
Contributor

jackfoxy commented Jul 7, 2018

marking as a bug for now, as all main collections data structures should have tests

@jackfoxy
Copy link
Contributor

jackfoxy commented Jul 7, 2018

added some tests, but ran into bug #123

@jackfoxy
Copy link
Contributor

jackfoxy commented Jul 8, 2018

Resolved #123 and found new bug, #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted 2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@panesofglass @misterspeedy @jackfoxy