Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Tabs on headpiece misconfigured, going crazy #321

Open
2 tasks done
callumlocke opened this issue Nov 6, 2016 · 2 comments
Open
2 tasks done

Tabs on headpiece misconfigured, going crazy #321

callumlocke opened this issue Nov 6, 2016 · 2 comments
Assignees

Comments

@callumlocke
Copy link
Contributor

callumlocke commented Nov 6, 2016

If this was an animated gif it would be flickering like crazy:

image

I suspect it's due to the fact that this JSON has switchTabEvery as null.

Two possible fixes (ideally we should do both):

  • fix code in next-front-page so it defaults to 5000 if it's null (NB. the ES6 default arg here only applies if it's undefined, not if it's null) — @Aendrew
  • fix the JSON so it is guaranteed always to have a sensible value for switchTabEvery@Aendrew or @kavanagh
@kavanagh
Copy link
Member

kavanagh commented Nov 6, 2016

My bad. This happened because I added it to the spreadsheet.

I already have a fix to prevent this, I just need to merge it.

In the meantime I put values in the spreadsheet.

@kavanagh
Copy link
Member

kavanagh commented Nov 7, 2016

@Aendrew is fixing the home page. We're going to do it slightly differently to what you suggested @callumlocke: If the poll interval is undefined, null or less than 1 second then polling is disabled.

Hopefully (once we have an initial implementation done) we can also have a look at following the results page logic which also has a basic backoff implementation: polling increases after a failed attempt and then stops after 3 retries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants