You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
If this was an animated gif it would be flickering like crazy:
I suspect it's due to the fact that this JSON has switchTabEvery as null.
Two possible fixes (ideally we should do both):
fix code in next-front-page so it defaults to 5000 if it's null (NB. the ES6 default arg here only applies if it's undefined, not if it's null) — @Aendrew
fix the JSON so it is guaranteed always to have a sensible value for switchTabEvery — @Aendrew or @kavanagh
The text was updated successfully, but these errors were encountered:
@Aendrew is fixing the home page. We're going to do it slightly differently to what you suggested @callumlocke: If the poll interval is undefined, null or less than 1 second then polling is disabled.
Hopefully (once we have an initial implementation done) we can also have a look at following the results page logic which also has a basic backoff implementation: polling increases after a failed attempt and then stops after 3 retries.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If this was an animated gif it would be flickering like crazy:
I suspect it's due to the fact that this JSON has
switchTabEvery
asnull
.Two possible fixes (ideally we should do both):
5000
if it's null (NB. the ES6 default arg here only applies if it'sundefined
, not if it'snull
) — @AendrewswitchTabEvery
— @Aendrew or @kavanaghThe text was updated successfully, but these errors were encountered: