Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g-chartcolour being imported incorrectly #117

Open
aendra-rininsland opened this issue Mar 22, 2018 · 2 comments
Open

g-chartcolour being imported incorrectly #117

aendra-rininsland opened this issue Mar 22, 2018 · 2 comments

Comments

@aendra-rininsland
Copy link
Member

Currently, some charts import g-chartcolour as follows:

import gChartColour from 'g-chartcolour';

This works fine using d3-bootloader but makes interoperability with other build systems difficult, given that g-chartcolour just exports each scale instead of collecting them as a default export. Instead, the following syntax is more accurate:

import * as gChartColour from 'g-chartcolour';
@bobhaslett
Copy link
Contributor

bobhaslett commented Aug 3, 2018

Just going through some of the VVT issues. If I replace

import gChartColour from 'g-chartcolour';

with

import * as gChartColour from 'g-chartcolour';

then the template falls over. I get

gChartcolour is not defined

so I've just left them as they are

@aendra-rininsland
Copy link
Member Author

Hm, might be something I need to tweak in d3-bootloader, will investigate further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants