Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for common code #9

Open
1 of 4 tasks
aendra-rininsland opened this issue Jun 27, 2017 · 3 comments
Open
1 of 4 tasks

Unit tests for common code #9

aendra-rininsland opened this issue Jun 27, 2017 · 3 comments

Comments

@aendra-rininsland
Copy link
Member

aendra-rininsland commented Jun 27, 2017

While I think it's a bit too ambitious to consider trying to get this to 100% coverage, we should definitely find some way to test component code (axes, frames, etc.) so we can ensure changes don't add regressive bugs.

Add tests to the following; get above ≅90% coverage (where applicable)

  • g-chartcolour
  • g-chartframe
  • g-axis
  • g-legend
@sdbernard
Copy link
Contributor

I think Tom has tests set up on g-chartframe and g-chartcolors

@aendra-rininsland
Copy link
Member Author

@sdbernard I just looked at both of those, g-chartframe has one functional test (estimated code coverage is ~5-10%), and g-chartcolour only has a test stub (0% coverage).

@aendra-rininsland
Copy link
Member Author

I've added code coverage reports to everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants