Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query params keep on getting added to the end #23

Open
jiangts opened this issue Feb 9, 2019 · 1 comment
Open

query params keep on getting added to the end #23

jiangts opened this issue Feb 9, 2019 · 1 comment

Comments

@jiangts
Copy link

jiangts commented Feb 9, 2019

I'm calling navigate! with the same route and params, but changing the 3rd argument, the query, causes a new set of query params to be added to the end of the URL. (instead of clearing out the previous keys).

For example, from the README if I do

(r/navigate! router :myapp/user-by-id {:id 2} {:foobar 1})
;; => "/api/users/2?foobar=1"

(r/navigate! router :myapp/user-by-id {:id 2} {:foobar 2})
;; => "/api/users/2?foobar=1?foobar=2"

jiangts added a commit to jiangts/bide that referenced this issue Feb 9, 2019
honestly, you should use goog.Uri.QueryData. It's very well tested + feature complete...
@jiangts
Copy link
Author

jiangts commented Feb 9, 2019

I see, this is the same as #15. It'd be helpful to cut a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant