Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use environment variables available through Schema's #67

Open
maxgaurav opened this issue Feb 23, 2018 · 1 comment
Open

Why not use environment variables available through Schema's #67

maxgaurav opened this issue Feb 23, 2018 · 1 comment

Comments

@maxgaurav
Copy link

As mentioned in the readme about constants, we are typically hardcoding the API URL into the application.

There are many times the app needs to run with staging, development and production environment API's and each of them may have different urls. Hard coding them in constants seems to add more logic to check the current environment and then act upon it.

With multiple schemas with their own environment variables solves the problem.

@irrelevantat
Copy link
Contributor

Yes, it's definitely a downside to add more logic for different environment URLs.
Personally I have made good experiences with being able to dynamically change the environment even in the app (though that will introduce even more complexity, as you pointed out).

Having said that, which paragraph are you referring to?
The part about constants doesn't really recommend hardcoding the API URL, it just provides an example of how to use constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants