-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as user I'd like to see different color markers on map so that I can easily understand how many they are of the same collection/category #17
Comments
fixed in 1.4.7 |
Thank you for being so fast! |
Yourwelcome |
Seems to have regressed (v1.7.5). |
@Lee-Carre can you explain? |
Apologies. From the OP:
Even with v1.7.6 I still observe the described behaviour. I never see any other colours, despite having multiple sets of PoIs loaded (I'm different categories), and querying an area which has matches from multiple sets / categories. I'll see if I can figure out how to upload a display-capture image. |
Yes, all markers are blue, but the number inside has a distinctive colour. |
Ironically, I'm having trouble with displaying the map at all. Often (but not always) it stalls at a mostly-white display. No background map, no radius rings, no PoI markers (of any colour 😆). See #27. I'm puzzled, still, as to what conditions trigger it (for reliable reproduction steps). 🤷♂️ |
Ah, and PinPoi depends on its hosted services, rather than being part of the app and merely fetching OSM Carto tiles? Seems like that's a separate matter to resolve (first). Else, how does map rendering work in PinPoi? Though, even before the Russia–Ukraine conflict, I had trouble with loading the map, sometimes. |
@Lee-Carre Any contribution is welcome. |
Today, I've noticed other projects which are using Leaflet without trouble (maps displaying as expected). Moments ago, I also successfully had PinPoi render a map of PoIs. Unfortunately, all from the same category, so I'm still unable to confirm (or refute) the question about colouring of markers / pins 🤨. I'm suspecting that it has something to do with how many nodes are in the set. A small count of PoIs tends to succeed more often than many. |
Right. I finally found a combination which worked. 🥳🕺 So, I can, indeed, confirm your description: each pin is blue (regardless of category), but the numeral it shows is differently-coloured (seemingly based on dataset within a category, based on how I'm invoking it). Trouble is, they're not clearly distinct (especially when displaying many pins). So, what I think the OP was seeking, was for the entire pin to be colour-coded (not just the numeral), so that they're very clearly distinct. Is this some limitation of Leaflet, that all pins must be blue? |
If I got your question, Leaflet Markers are made with a DefaultIcon 🤔 |
Currently custom icon is generated using the Enhance this feature is an interesting task, I see some issues:
Again, contributions are welcome. |
When you see al the markers on the map they are all blue with a number on it, would be fine if they are of the same category/collection.
Having coloured collections or categories IMO can help understanding how many markers are the same.
I think having a randomly assigned colour may be enough for start, otherwise a full feature would allow to choose the colour during creation/editing
The text was updated successfully, but these errors were encountered: