Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as user I'd like to see different color markers on map so that I can easily understand how many they are of the same collection/category #17

Closed
tassoman opened this issue Feb 19, 2017 · 15 comments
Assignees

Comments

@tassoman
Copy link

When you see al the markers on the map they are all blue with a number on it, would be fine if they are of the same category/collection.

Having coloured collections or categories IMO can help understanding how many markers are the same.

I think having a randomly assigned colour may be enough for start, otherwise a full feature would allow to choose the colour during creation/editing

@fvasco fvasco self-assigned this Feb 20, 2017
@fvasco
Copy link
Owner

fvasco commented Feb 20, 2017

fixed in 1.4.7

@fvasco fvasco closed this as completed Feb 20, 2017
@tassoman
Copy link
Author

Thank you for being so fast!

@fvasco
Copy link
Owner

fvasco commented Feb 25, 2017

Yourwelcome

@Lee-Carre
Copy link

Seems to have regressed (v1.7.5).

@fvasco
Copy link
Owner

fvasco commented Jan 19, 2022

@Lee-Carre can you explain?
Colors are consistent in each search.

@Lee-Carre
Copy link

@fvasco

Apologies.

From the OP:

When you see al the markers on the map they are all blue …

Even with v1.7.6 I still observe the described behaviour. I never see any other colours, despite having multiple sets of PoIs loaded (I'm different categories), and querying an area which has matches from multiple sets / categories.

I'll see if I can figure out how to upload a display-capture image.

@fvasco
Copy link
Owner

fvasco commented Jan 25, 2022

Yes, all markers are blue, but the number inside has a distinctive colour.
Can you confirm, @Lee-Carre?

@Lee-Carre
Copy link

Lee-Carre commented Mar 12, 2022

all markers are blue, but the number inside has a distinctive colour. Can you confirm[…]?

Ironically, I'm having trouble with displaying the map at all. Often (but not always) it stalls at a mostly-white display. No background map, no radius rings, no PoI markers (of any colour 😆). See #27.

I'm puzzled, still, as to what conditions trigger it (for reliable reproduction steps).

🤷‍♂️

@fvasco
Copy link
Owner

fvasco commented Mar 13, 2022

@Lee-Carre
Copy link

The library's support has been discontinued.

Ah, and PinPoi depends on its hosted services, rather than being part of the app and merely fetching OSM Carto tiles?

Seems like that's a separate matter to resolve (first).

Else, how does map rendering work in PinPoi?

Though, even before the Russia–Ukraine conflict, I had trouble with loading the map, sometimes.
Though, seems that debugging is not possible, for now.

@fvasco
Copy link
Owner

fvasco commented Mar 14, 2022

@Lee-Carre
PinPoi uses LeafLet and OSM to render map.

https://github.com/fvasco/pinpoi/blob/master/app/src/main/java/io/github/fvasco/pinpoi/PlacemarkListActivity.kt#L150

Any contribution is welcome.

@Lee-Carre
Copy link

Lee-Carre commented Mar 16, 2022

Today, I've noticed other projects which are using Leaflet without trouble (maps displaying as expected).

Moments ago, I also successfully had PinPoi render a map of PoIs. Unfortunately, all from the same category, so I'm still unable to confirm (or refute) the question about colouring of markers / pins 🤨.

I'm suspecting that it has something to do with how many nodes are in the set. A small count of PoIs tends to succeed more often than many.

@Lee-Carre
Copy link

@fvasco

all markers are blue, but the number inside has a distinctive colour. Can you confirm[…]?

Right. I finally found a combination which worked. 🥳🕺

So, I can, indeed, confirm your description: each pin is blue (regardless of category), but the numeral it shows is differently-coloured (seemingly based on dataset within a category, based on how I'm invoking it).


Trouble is, they're not clearly distinct (especially when displaying many pins). So, what I think the OP was seeking, was for the entire pin to be colour-coded (not just the numeral), so that they're very clearly distinct.

Is this some limitation of Leaflet, that all pins must be blue?

@tassoman
Copy link
Author

If I got your question, Leaflet Markers are made with a DefaultIcon 🤔

@fvasco
Copy link
Owner

fvasco commented Mar 20, 2022

Currently custom icon is generated using the Leaflet.Icon.Glyph library.
I already pointed to interesting code.

Enhance this feature is an interesting task, I see some issues:

  1. we need to find some candidate colours for new markers, these colours do have to be confused with map items.
  2. we need to find/draw these markers, without any legal issues.
  3. we have to find good pairs of marker colour / text colour, keeping in mind colour blindness issue.

Again, contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants