Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling in wasm_interface #23

Open
Mohammad-nassar10 opened this issue Jun 28, 2021 · 2 comments
Open

Improve error handling in wasm_interface #23

Mohammad-nassar10 opened this issue Jun 28, 2021 · 2 comments
Assignees
@Mohammad-nassar10
Labels
WASM

Comments

@Mohammad-nassar10
Copy link
Contributor

Mohammad-nassar10 commented Jun 28, 2021 •
edited
Loading

Define a proper way to handle errors.
Errors may happen in JNI interface when trying to parse a string from a parameter. For example in wasm_instance function in allocator_jni.rs file: let input: String = jre.get_string(path).expect("Couldn't get java string!").into();.
@roee88
Copy link
Collaborator

roee88 commented Jun 28, 2021

Please provide more context to the issue description

@roee88 roee88 changed the title Error handling Improve error handling in wasm_interface Jul 6, 2021
@roee88
Copy link
Collaborator

roee88 commented Jul 6, 2021

Reference: #20 (comment)

@roytman roytman added the WASM label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mohammad-nassar10 Mohammad-nassar10

Labels
WASM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roee88 @roytman @Mohammad-nassar10