-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'contact' to something more explicit #69
Comments
Migrating discussion from PR #65: From @fschiettecatte:
From @Relequestual:
|
Oh, actually, now I see option 2 clearly presented, I think that would be preferable. Meta-data contact, to me, makes it clear that it's not contact details of the patient, but contact details regarding their data. |
+1 for @Relequestual's comments, make it clear it is separate from the patient and call it whatever makes sense. |
I propose closing this as an unnecessary backwards-incompatible change, or pushed to 2.0. |
I'll migrate this to 2.0 milestone and we can address it there if we still feel it's needed. |
As suggested by GA4GH metadata: ga4gh/ga4gh-schemas#234
Since the 'contact' field is within each 'patient' object, it makes it look like these are the contact details for the patient, rather than the submitter/owner.
There are several decent options that I see:
The text was updated successfully, but these errors were encountered: