Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported feature handling/error codes #84

Open
allasm opened this issue Feb 19, 2015 · 6 comments
Open

Unsupported feature handling/error codes #84

allasm opened this issue Feb 19, 2015 · 6 comments

Comments

@allasm
Copy link
Contributor

allasm commented Feb 19, 2015

We should agree how a matcher should indicate that certain data in a query was ignored when performing matching - either because certain optional fields were not supported, or because some of the required fields contain data in an unsupported ontology/format (e.g. a matcher may support MIM and not Orphanet, or only know assembly X and not Y)

@allasm allasm added this to the v1.1 milestone Feb 19, 2015
@Relequestual
Copy link
Member

How would that information be used? What's the Use Case for wanting this?

@Relequestual
Copy link
Member

@buske @fschiettecatte Any further thoughts on this? I could see it may be useful for development purposes, but otherwise, how could it be displayed to the end user and under what conditions?
Can anyone think of practical examples where this information would be informative, and the potential formats it might?

@fschiettecatte
Copy link
Contributor

I would agree with @Relequestual that this might be useful for testing, but I am not sure of the ROI needed to spec, implement and support.

@Relequestual Relequestual removed their assignment Sep 30, 2015
@buske
Copy link
Member

buske commented Oct 19, 2015

I think it is useful for two reasons:

  • testing and debugging
  • transparency (what information was received and used)

I find the latter to be a much stronger argument. A simple way to implement this is to have the response include a parsed version of the query. Fields that could not be parsed or interpreted, or were not used, would not be returned.

@Relequestual
Copy link
Member

I'm tempted to push this to v2.0. Thoughts?

Reviewing it now, my gut reaction is to allow simply plain text for this. If we're saying the simplest and actually useable use cases are for testing / debugging, and transparancy to the user, then english is probably the best form to do this.

We COULD come up with some meta language to describe how the query was transformed and executed, but then that opens a whole new can of worms of standards of meta data. If we see value in that in terms of machine readable information which could suggest which tunable elements to tweak, then I think we could pass on this query to the Meatadata Task Team.

For now, a human readable field would seem appropriate, and could be part of 1.1, but I think it may fit better with the modular vision for 2.0. I think the gain would be grater as part of 2.0 than 1.1, but open to hearing arguments either way.

@buske
Copy link
Member

buske commented Mar 6, 2016

I think we should put this off to 2.0.

@Relequestual Relequestual modified the milestones: 2.0 alpha, v1.1 Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants